Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compat-helper #58

Merged
merged 2 commits into from
Jun 14, 2022
Merged

add compat-helper #58

merged 2 commits into from
Jun 14, 2022

Conversation

oscardssmith
Copy link
Contributor

No description provided.

@mortenpi
Copy link
Member

mortenpi commented Jun 10, 2022

Not saying that this is a bad idea, but is there any particular motivation to add it right now? I am subscribed to a few repositories that use it, and I find it a little too noisy at times.

@oscardssmith
Copy link
Contributor Author

oscardssmith commented Jun 10, 2022

I went through the 80 dependents of AbstractTrees to find package that didn't have compathelper and have dependents since we just tagged 0.4.

@serenity4
Copy link
Contributor

Having compat helper would help avoid (or catch) some bugs related to version mismatches, see #59.

@MichaelHatherly
Copy link
Member

Having compat helper would help avoid (or catch) some bugs related to version mismatches, see #59.

I had assumed, wrongly, that CompatHelper was running on this repo, otherwise I would have done that bump manually when I tagged 0.9.

I find it a little too noisy at times.

It might sometimes be a little noisy, but it does help automate a process that is otherwise quite messy if it needs to always be handled manually for every dep.

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair points. It's actually easy to forget this repo, so that occasional noise is probably a good thing.

.github/workflows/CompatHelper.yml Outdated Show resolved Hide resolved
@mortenpi mortenpi merged commit aba0a4e into JuliaDocs:master Jun 14, 2022
@mortenpi
Copy link
Member

I went ahead and merged with the latest recommended version of the file. Thanks for raising this @oscardssmith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants