Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching versions resets to the default page #2479

Open
j-adel opened this issue Mar 9, 2024 · 3 comments
Open

Switching versions resets to the default page #2479

j-adel opened this issue Mar 9, 2024 · 3 comments
Labels
Format: HTML Related to the default HTML output help wanted Type: Enhancement

Comments

@j-adel
Copy link

j-adel commented Mar 9, 2024

When searching for something in a package, Google usually points to an outdated version. Normally, this wouldn't be an issue since you can switch to the latest version on the bottom left. The only issue is that doing so directs me to the home page of the documentation instead of sending me to the same page in the new version. I understand that sometimes the page is no longer there but I think at least attempting the redirect to the new version's page and if it fails would send the user to the homepage.

@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output help wanted labels Mar 10, 2024
@mortenpi
Copy link
Member

I thought we already have an issue for this, but I couldn't find it.

I understand that sometimes the page is no longer there but I think at least attempting the redirect to the new version's page which if fails would send the user to the homepage.

Yea, that's the main issue here. But, before redirecting, we could probably do a fetch to the presumed exact URL, see if the page is there, and if it is not, then navigate to the root.

Google usually points to an outdated version

Just as a note: this should not really be true for the most part. Documenter should show a banner on an outdated version, which also also sets noindex tags, and it also sets up canonical URLs:

image

What might be happening is that the old documentation is very old (predates the banner etc). In that case, the maintainers should add the banner with DocumenterTools.

@j-adel
Copy link
Author

j-adel commented Mar 10, 2024

Yes, I think this is a case of older versions of a package using older versions of Documenter.jl, and maintainers forget to update it. I can submit an issue of this when I see it in other packages. Is there a guide somewhere that I can direct the developers to when submitting an issue? (I suppose I could also try a PR myself)

@fredrikekre
Copy link
Member

With #1411 it would be possible to redirect blindly amd have the 404 inte page mention that "maybe this page don't exist for this version" as a probabe cause or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output help wanted Type: Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants