Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variable names to symbols #147

Closed
2 tasks
dpsanders opened this issue Feb 20, 2018 · 3 comments
Closed
2 tasks

Change variable names to symbols #147

dpsanders opened this issue Feb 20, 2018 · 3 comments

Comments

@dpsanders
Copy link
Contributor

dpsanders commented Feb 20, 2018

  • Use :x instead of "x"
  • Provide a Dict to look up which number variable a given symbol corresponds to.
@lbenet
Copy link
Member

lbenet commented Feb 21, 2018

I don't mind the first option.

Regarding the second one, I think we can get it directly as look_up(:x) with the function

lookup(s::Symbol) = find(v -> v==s, TaylorSeries._params_TaylorN_.variable_symbols)

It would return a vector with the index where the symbol is found, or a zero-length vector, if the symbol doesn't exist.

@lbenet
Copy link
Member

lbenet commented Feb 22, 2018

This is only partially addressed by #154, shall we close this, or keep it open for the future?

@lbenet
Copy link
Member

lbenet commented Feb 23, 2018

Closing, since this is somehow provided by #154 and #155

@lbenet lbenet closed this as completed Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants