-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the rrule for 3-arg dot lazy #788
Comments
I guess the key question is are we willing to add LazyArrays as a dependency? |
Since this seems to have come up twice in two different contexts i think we can say that this is worth it and we should add LazyArrays as a dependency. |
I am able to yes. I will do it in the weekend unless someone wants to beat me to it. It's basically exactly this implementation https://discourse.julialang.org/t/zygote-jl-how-to-get-the-gradient-of-sparse-matrix/59067/12 plus unit tests. |
Hello, are there any news about this? I would like to implement reverse diff to |
Currently this line
ChainRules.jl/src/rulesets/LinearAlgebra/dense.jl
Line 38 in 9f1817a
m x n
matrix's co-tangent only requiresO(m + n)
memory. See https://discourse.julialang.org/t/zygote-jl-how-to-get-the-gradient-of-sparse-matrix/59067/12 for the potential gain and suggested implementation. If the idea gets a green light, I will open a PR.The text was updated successfully, but these errors were encountered: