Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing non-differentiable rules with varargs #253

Closed
oxinabox opened this issue Aug 28, 2020 · 3 comments
Closed

Add missing non-differentiable rules with varargs #253

oxinabox opened this issue Aug 28, 2020 · 3 comments
Labels

Comments

@oxinabox
Copy link
Member

oxinabox commented Aug 28, 2020

#252 doesn't include anything that has varargs.

These should be added.
Either by defining the frules and rrules manually,
or by completing JuliaDiff/ChainRulesCore.jl#212

Assuming the latter is done, the missing lines are:

@non_differentiable *(::Union{Regex, AbstractChar, AbstractString}...)
@non_differentiable abspath(::AbstractString...)
@non_differentiable gensym(::String...)
@non_differentiable joinpath(::AbstractString, ::AbstractString...)
@non_differentiable normpath(::AbstractString...)
@non_differentiable print(::Any...)
@non_differentiable println(::Any...)
@non_differentiable string(::Any...)
@non_differentiable write(::IO, ::Any...)
@non_differentiable isassigned(::Any...)
@non_differentiable isblockdev(::Any...)
@non_differentiable ischardev(::Any...)
@non_differentiable isdir(::Any...)
@non_differentiable isfifo(::Any...)
@non_differentiable isfile(::Any...)
@non_differentiable islink(::Any...)
@non_differentiable ismount(::Any...)
@non_differentiable ispath(::Any...)
@non_differentiable eachindex(::Any...)
@non_differentiable xor(Any...)

@non_differentiable Broadcast.combine_styles(::Any...)

@non_differentiable Core.print(::Any...)
@non_differentiable Core.println(::Any...)

@non_differentiable rand(::Any...)
@non_differentiable randn(::Any...)
@non_differentiable randexp(::Any...)

#252 includes all of these manually splatted to betwen 3 and 5 entries, which should be deleted

@oxinabox
Copy link
Member Author

oxinabox commented Sep 2, 2020

@non_differentiable eachindex(::Any...)

@gxyd
Copy link
Contributor

gxyd commented Dec 4, 2020

#252 doesn't include anything that has varargs.
These should be added.
Either by defining the frules and rrules manually,
or by completing JuliaDiff/ChainRulesCore.jl#212

JuliaDiff/ChainRulesCore.jl#212 has been fixed, probably this can be taken up.

@oxinabox oxinabox added the good first issue Good for newcomers label Dec 8, 2020
@niklasschmitz
Copy link
Contributor

Hey, I'd be happy to try a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants