fix error in error #350
Merged
fix error in error #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericphanson
commented
Oct 20, 2023
| @@ -126,14 +126,14 @@ end | |||
|
|
|||
| function subset(x::DictRowTable, inds; viewhint::Union{Bool,Nothing}=nothing, view::Union{Bool,Nothing}=nothing) | |||
| if view !== nothing | |||
| @warn "`view` keyword argument is deprecated for `Tables.subset`, use `viewhint` instead" | |||
| @warn "`view` keyword argument is deprecated for `Tables.subset`, use `viewhint` instead" maxlog=10 | |||
There was a problem hiding this comment.
unrelated change but deprecation-style warnings should generally get a maxlog imo
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 7 7
Lines 739 739
=======================================
Hits 699 699
Misses 40 40
☔ View full report in Codecov by Sentry. |
bkamins
approved these changes
Oct 21, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiny fix since
retisn't defined. (found by JET!)