Skip to content

Commit

Permalink
Don't match on AbstractVector type parameter due to compiler crash (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
quinnj authored and bkamins committed Aug 24, 2020
1 parent 51b4422 commit 71843b1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "DataFrames"
uuid = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
version = "0.21.6"
version = "0.21.7"

[deps]
CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"
Expand Down
4 changes: 2 additions & 2 deletions src/groupeddataframe/splitapplycombine.jl
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,7 @@ function copyto_widen!(res::AbstractVector{T}, x::AbstractVector) where T
end

function groupreduce!(res::AbstractVector, f, op, condf, adjust, checkempty::Bool,
incol::AbstractVector{T}, gd::GroupedDataFrame) where {T}
incol::AbstractVector, gd::GroupedDataFrame)
n = length(gd)
if adjust !== nothing || checkempty
counts = zeros(Int, n)
Expand Down Expand Up @@ -995,7 +995,7 @@ function groupreduce!(res::AbstractVector, f, op, condf, adjust, checkempty::Boo
end
@inbounds for gix in eachindex(res)
if !isassigned(res, gix)
res[gix] = initf(nonmissingtype(T))
res[gix] = initf(nonmissingtype(eltype(incol)))
end
end
end
Expand Down

2 comments on commit 71843b1

@bkamins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register branch=v0.21_patches

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/20126

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.21.7 -m "<description of version>" 71843b1226f6c8d06121c4e763bf29d8a3da107b
git push origin v0.21.7

Please sign in to comment.