Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectFile has a None option #182

Open
mbauman opened this issue Jun 3, 2020 · 5 comments
Open

ProjectFile has a None option #182

mbauman opened this issue Jun 3, 2020 · 5 comments
Labels
Julia v1.0 Impacted by support for v1.0

Comments

@mbauman
Copy link
Member

mbauman commented Jun 3, 2020

This was a little funny:

ProjectFile keywords to customize:
[press: d=done, a=all, n=none]
   [X] version
 > [X] None

With both selected, the None option seemed to win. Seems like this None option should be removed.

@christopher-dG
Copy link
Member

It's an implementation detail of TerminalMenus, you can't create a menu with just one entry. 🙁

@mbauman
Copy link
Member Author

mbauman commented Jun 4, 2020

Ah, that's unfortunate. Perhaps this should be an upstream issue? Seems like a 1-element menu should make sense and be easy to support.

cf. JuliaLang/julia#35915 (comment)

@christopher-dG
Copy link
Member

Yeah, I agree. Tbh we're probably better off using the non-stdlib version because the stdlib will never backport these kinds of changes to 1.0.

@tomyun
Copy link

tomyun commented Jun 22, 2020

FYI, single option menu for REPL.TerminalMenus just got merged (likely available with Julia 1.6+): JuliaLang/julia#36369

@christopher-dG
Copy link
Member

I think some people have said that 1.6 has potential to be the next LTS, so when that comes we can make the change 🙂

@nickrobinson251 nickrobinson251 added the Julia v1.0 Impacted by support for v1.0 label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Julia v1.0 Impacted by support for v1.0
Projects
None yet
Development

No branches or pull requests

4 participants