Update Project.toml #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
requested changes
Jul 30, 2019
| @@ -1,15 +1,15 @@ | |||
| name = "UnitfulAstro" | |||
| uuid = "f2a1aa4e-5634-4978-a6f6-8c9e368f14ef" | |||
| license = "MIT" | |||
| version = "0.2.0" | |||
| version = "0.3.0" | |||
There was a problem hiding this comment.
The version number should be incremented only on the commit that will mark a new release. Is this the case?
There was a problem hiding this comment.
The problem is that currently if you install UnitfulAstro 0.2.0 you get the release version which does not contain the magnitudes and other changes since November. You have to install UnitfulAstro#master which is still 0.2.0 but has different functionality. It would be nice to have at least 0.2.1 such that someone can pin UnitfulAstro to use the magnitudes.
This came up because I want to use the magnitudes in some of the calculations for Spectra.jl
|
I guess you'd like a new release now, right? |
|
If it is convenient for you, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes version to 0.3 which has magnitude support. I've also changed the compat section to use semantic versioning
^instead of>=.