Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base.reinterpret() #13

Merged
merged 4 commits into from
Jul 2, 2022
Merged

Base.reinterpret() #13

merged 4 commits into from
Jul 2, 2022

Conversation

green-nsk
Copy link
Contributor

related to #12
Just some work I did before I noticed there was already an WIP branch on origin

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #13 (53e8df5) into main (654d42a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   99.16%   99.21%   +0.05%     
==========================================
  Files           3        3              
  Lines         120      128       +8     
==========================================
+ Hits          119      127       +8     
  Misses          1        1              
Impacted Files Coverage Δ
src/unsafe_array.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 654d42a...53e8df5. Read the comment docs.

@oschulz
Copy link
Collaborator

oschulz commented Jul 1, 2022

Thanks for contributing, @green-nsk . Could you see if the Julia v1.0 test failures can be fixed easily? If not, we could consider requiring Julia v1.6.

@green-nsk
Copy link
Contributor Author

ERROR: LoadError: LoadError: syntax: invalid assignment location "s..."

Looking at the error message, this might fix it. Though I'll have to rely on GH workflows to see if it does -- I don't have Julia 1.0 handy.

@oschulz
Copy link
Collaborator

oschulz commented Jul 2, 2022

Looking at the error message, this might fix it.

Looks like it did. .-)

@oschulz oschulz merged commit 204fcd9 into JuliaArrays:main Jul 2, 2022
@oschulz
Copy link
Collaborator

oschulz commented Jul 2, 2022

Thanks @green-nsk

@oschulz
Copy link
Collaborator

oschulz commented Jul 2, 2022

@green-nsk green-nsk deleted the reinterpret_ branch July 4, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants