Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we contextualize parent_type? #9

Open
Tokazama opened this issue Mar 16, 2022 · 0 comments
Open

Can we contextualize parent_type? #9

Tokazama opened this issue Mar 16, 2022 · 0 comments

Comments

@Tokazama
Copy link
Member

When I made this PR to base some good points were brought up about what we knew about parent(x) compared to x. With a few exceptions (that we should probably clean up), we simply use parent_type as convenient syntax for communicating the type of the underlying data buffer/collection. An informal search through juliahub shows that a handful of packages define something very similar independent of this package, so it's clearly something that has utility already. I'd like to know if we could do better.

The biggest hangup here is how we succinctly describe what assumptions persists between x and parent(x). The only approachable idea I have is a method like is_lazy_wrapper when we can assume that the wrapper type changes nothing. However, that seems extremely limiting and questionably useful.

A more approachable aspect to this is describing the kind of type that is parent_type(x). For example, sub-typing something like BufferStyle with these subtypes:

  • WrappedBuffer: single wrapped buffer like SubArray.
  • MultiBuffer: multiple distinct buffers like Tridiagonal
  • ComputedBuffer: buffer is computed on the fly and isn't stored in memory (e.g., FillArrays).

However, creating traits for describing parent_type(x) isn't terribly useful until we have a generic approach for doing f(x) = f(parent(x)).

@ChrisRackauckas ChrisRackauckas transferred this issue from JuliaArrays/ArrayInterface.jl Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant