Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardDiff vs BigFloat in SemiclassicalJacobiWeight #73

Open
ioannisPApapadopoulos opened this issue Apr 12, 2023 · 1 comment
Open

Comments

@ioannisPApapadopoulos
Copy link
Member

So I modified lines 49-52 in src/SemiclassicalJacobiPolynomials.jl from (t,a,b,c) = map(big, map(float, (P.t,P.a,P.b,P.c))) to (t,a,b,c) = P.t, P.a, P.b, P.c. This was because otherwise I was not able to use ForwardDiff to take derivatives of various things in the tests for twoband.

This seems to be an issue in general, I think we definitely need to use BigFloats here. Is there a smart way to get ForwarDiff working even after mapping to BigFloats? Or should I just harcode the tests to not use ForwardDiff?

@dlfivefifty
Copy link
Member

If it doesn’t work that’s a bug in ForwardDiff.jl, so we just need to make a PR. (The bug would be that big(::Dual) doesn’t make a Dual{<:BigFloat}.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants