Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an example for entropy simulation. #493

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added an example for entropy simulation. #493

wants to merge 4 commits into from

Conversation

DoktorMike
Copy link

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #492

How did you address these issues with this PR? What methods did you use?

I just made a small example and put it in a file called entropy.jl under examples. Nothing else touched.

@DoktorMike
Copy link
Author

See https://discourse.julialang.org/t/javis-collision-detection/87398/10 for a discussion on the example and why I submitted this. :)

@Sov-trotter
Copy link
Member

Sov-trotter commented Sep 20, 2022 •
edited
Loading

Thanks for this!
Could you also add an animation gif to the gifs folder? https://github.com/JuliaAnimators/Javis.jl/tree/main/examples/gifs

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022 •
edited
Loading

Codecov Report

Merging #493 (c54222c) into main (1e74392) will decrease coverage by 0.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   77.74%   77.24%   -0.51%     
==========================================
  Files          38       38              
  Lines        1991     2070      +79     
==========================================
+ Hits         1548     1599      +51     
- Misses        443      471      +28
Impacted Files Coverage Δ
src/action_animations.jl 95.37% <0.00%> (-0.44%) ⬇️
src/Javis.jl 96.65% <0.00%> (-0.28%) ⬇️
src/Shape.jl 0.00% <0.00%> (ø)
src/backgrounds.jl 100.00% <0.00%> (ø)
src/luxor_utils.jl 100.00% <0.00%> (ø)
src/structs/JPath.jl 100.00% <0.00%> (ø)
src/util.jl 97.36% <0.00%> (+0.05%) ⬆️
src/structs/Frames.jl 96.72% <0.00%> (+0.05%) ⬆️
src/svg2luxor.jl 97.03% <0.00%> (+0.13%) ⬆️
src/structs/Object.jl 95.55% <0.00%> (+0.20%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DoktorMike
Copy link
Author

Thanks for this! Could you also add an animation gif to the gifs folder? https://github.com/JuliaAnimators/Javis.jl/tree/main/examples/gifs

Done.

@TheCedarPrince
Copy link
Member

I activated the CI for this - will review this PR asap and see if we can get this merged. Thanks @DoktorMike - you the best! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArbitRandomUser ArbitRandomUser ArbitRandomUser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Educational Entropy example
5 participants
@DoktorMike @Sov-trotter @codecov-commenter @TheCedarPrince @ArbitRandomUser