Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Enzyme in [weakdeps] to 0.13, (keep existing compat) #275

Conversation

github-actions[bot]
Copy link

This pull request changes the compat entry for the Enzyme package from 0.12 to 0.12, 0.13.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-09-19-01-00-46-351-01475325828 branch from b264af5 to ec31341 Compare September 19, 2024 01:00
@sefffal
Copy link

sefffal commented Nov 8, 2024

Would it be possible to merge this? Pigeons currently holds back Enzyme.

PS. if a repo owner makes a comment on a PR by compat-helper, that will trigger any CI (external PRs don't run CI).

Thanks!

@alexandrebouchard
Copy link
Member

Sounds good, just had to merge two compat lines, waiting for the tests to complete...

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (aa92864) to head (e0041d9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         103      103           
  Lines        2570     2570           
=======================================
  Hits         2242     2242           
  Misses        328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexandrebouchard alexandrebouchard merged commit 25051cd into main Nov 8, 2024
13 checks passed
@alexandrebouchard alexandrebouchard deleted the compathelper/new_version/2024-09-19-01-00-46-351-01475325828 branch November 8, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants