Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRTs: Channel revenue doesn't show non-video revenue #6271

Open
mochet opened this issue May 8, 2024 · 2 comments
Open

CRTs: Channel revenue doesn't show non-video revenue #6271

mochet opened this issue May 8, 2024 · 2 comments
Labels
bug Something isn't working pending-triage Requires triage before any work can begin

Comments

@mochet
Copy link
Contributor

mochet commented May 8, 2024

Problem

I have issued a creator token and deposited validator rewards by just transferring them into the channel account. This does not reflect on the UI though and it shows that my CRT's "total revenue" is 0.

https://gleev.xyz/channel/24503?tab=Token

This may seem like an edge case that has small demand, but I think prevents more creative uses of creator tokens.

Solution

The "total revenue" should ideally include all deposits into the channel account instead of just YPP rewards.

@mochet mochet added bug Something isn't working pending-triage Requires triage before any work can begin labels May 8, 2024
@mochet
Copy link
Contributor Author

mochet commented May 13, 2024

To give an idea of the scale of this problem (I am describing the case of my own creator token):
Although the revenue isn't properly shown by the Gleev UI, at 35,720 $JOY in the revenue account and given the current revenue rate:

  • It would already be the 7th highest CRT in terms of revenue
  • within 30 days it would be the 4th highest CRT in terms of revenue
  • within 60 days it would be the 3rd highest CRT in terms of revenue

@bedeho
Copy link
Member

bedeho commented May 13, 2024

This is probably because total revenue number is just based on member remark based payments, not including raw transfers. Including raw transfers would be possible, requires extra mappings, not sure where to prio it exactly, for reasons that you yourself state. Will link to this from new issue no Orion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending-triage Requires triage before any work can begin
Projects
None yet
Development

No branches or pull requests

2 participants