Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump minimum Node version to 18.12 and TypeScript to 4.8.4 #531

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 22, 2024

PR Checklist

Overview

Removes the following methods that rely on deprecated parts of TypeScript:

  • isInputFiles (ts.SyntaxKind.InputFiles)
  • isUnparsedPrologue (ts.SyntaxKind.UnparsedPrologue)
  • isUnparsedSourceText (ts.isUnparsedPrepend, ts.isUnparsedTextLike)
  • isUnparsedSyntheticReference (ts.SyntaxKind. UnparsedSyntheticReference)

Also bumps all devDependencies to latest (ncu -u) to work on the latest Node 22 and 23 in CI.

💖

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat!: bump minimum Node version to 18.12 feat!: bump minimum Node version to 18.12 and TypeScript to 4.8.4 Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 58.03279% with 128 lines in your changes missing coverage. Please review.

Project coverage is 75.50%. Comparing base (c87c47b) to head (8911a4f).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/nodes/access.ts 35.00% 52 Missing ⚠️
src/usage/UsageWalker.ts 56.98% 40 Missing ⚠️
src/usage/getUsageDomain.ts 70.49% 18 Missing ⚠️
src/compilerOptions.ts 85.71% 4 Missing ⚠️
src/scopes.ts 55.55% 4 Missing ⚠️
src/comments.ts 0.00% 3 Missing ⚠️
src/usage/Scope.ts 0.00% 3 Missing ⚠️
src/types/utilities.ts 0.00% 2 Missing ⚠️
src/nodes/utilities.ts 0.00% 1 Missing ⚠️
src/usage/utils.ts 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c87c47b) and HEAD (8911a4f). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (c87c47b) HEAD (8911a4f)
4.6.4 1 0
4.9.5 1 0
4.3.5 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   80.59%   75.50%   -5.10%     
==========================================
  Files          35       50      +15     
  Lines        6575     4821    -1754     
  Branches      440      630     +190     
==========================================
- Hits         5299     3640    -1659     
+ Misses       1276     1180      -96     
- Partials        0        1       +1     
Flag Coverage Δ
4.3.5 ?
4.6.4 ?
4.8.4 74.25% <57.70%> (?)
4.9.5 ?
latest 75.25% <57.70%> (-5.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RebeccaStevens
Copy link
Collaborator

RebeccaStevens commented Nov 13, 2024

@JoshuaKGoldberg I updated a few things. LGTM now

@JoshuaKGoldberg JoshuaKGoldberg removed the status: blocked Waiting for something else to be resolved 🙅 label Nov 14, 2024
@JoshuaKGoldberg
Copy link
Owner Author

Great thanks! I think we should wait on #535 to get these merged in the same time, since #535 is a breaking change too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Drop support for TypeScript < 4.8.4 🚀 Feature: Drop support for Node 16
2 participants