Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Move release-it.d.ts to release-it or DefinitelyTyped #29

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 19, 2024 · 0 comments · Fixed by #363
Closed
3 tasks done

🛠 Tooling: Move release-it.d.ts to release-it or DefinitelyTyped #29

JoshuaKGoldberg opened this issue Jan 19, 2024 · 0 comments · Fixed by #363
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

https://github.com/webpro/release-it is written in JavaScript and doesn't ship its own .d.ts types. The general TypeScript community consensus for packages like that is to write the types in https://github.com/DefinitelyTyped/DefinitelyTyped. That'd be better than having a src/release-it.d.ts checked into this repo.

Once there are TypeScript types available for the release-it package, we can use them here. Accepting PRs!

Additional Info

cc @webpro as an FYI.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: tooling Managing the repository's maintenance type: cleanup Tech debt or other code/repository cleanups labels Jan 19, 2024
@webpro webpro mentioned this issue Jan 22, 2024
Merged
@markEHVN markEHVN mentioned this issue Dec 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove release-it.d.ts, upgrade release-it.d.ts version markEHVN/release-it-action
1 participant
@JoshuaKGoldberg