Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Stop publishing the demo on npm #97

Closed
2 tasks done
JoshuaKGoldberg opened this issue Oct 15, 2024 · 1 comment · Fixed by #104
Closed
2 tasks done

🚀 Feature: Stop publishing the demo on npm #97

JoshuaKGoldberg opened this issue Oct 15, 2024 · 1 comment · Fixed by #104
Labels
good first issue Good for newcomers, please hop on! 🙌 status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

I noticed while working on #89 & fixing up a few subsequent release issues that this package publishes the full demo/index.html (formerly, index.html) to npm. From...

I don't think folks who are installing this on npm need the demo. It's extra bloat in node_modules/ that we can get rid of.

Let's remove the demo/ directory from the package.json "files" entry:

https://github.com/JoshuaKGoldberg/package.json-validator/blob/84f76891ebc023ef43dcfd9a62c382f842887dea/package.json#L40

Additional Info

💖

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request 🚀 status: accepting prs Please, send a pull request to resolve this! 🙏 good first issue Good for newcomers, please hop on! 🙌 labels Oct 15, 2024
Copy link

🎉 This is included in version v0.7.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! 🙌 status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant