Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Testing: Fill in unit tests! #2

Open
3 tasks done
JoshuaKGoldberg opened this issue Mar 29, 2023 · 0 comments
Open
3 tasks done

🧪 Testing: Fill in unit tests! #2

JoshuaKGoldberg opened this issue Mar 29, 2023 · 0 comments
Labels
area: testing Improving how the repository's tests are run and/or code is tested area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

The initial commit for this repo has approximately zero unit test coverage 😄:

describe("githubSponsorsToMarkdown", () => {
	it("exists", () => {
		expect(githubSponsorsToMarkdown).toBeDefined();
	});
});

Let's add tests!

Additional Info

I'm pretty flexible here: as long as the test runs githubSponsorsToMarkdown and asserts the results look reasonable, I'm generally happy. The one trick is that the unit tests should not make network calls. They'll need to mock out the network call done by await graphqlWithAuth in some way, such as with a vitest module mock.

@JoshuaKGoldberg JoshuaKGoldberg added area: testing Improving how the repository's tests are run and/or code is tested area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing Improving how the repository's tests are run and/or code is tested area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Development

No branches or pull requests

1 participant