Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unusable message IDs #639

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Removes the unreachable FileIsNotIncludedInTSConfig and Multiple$ExpectTypeAssertions message IDs.

Also fills in some tests around snapshots (#114) to feel more safe in doing so.

💖

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (1d78300) to head (a9f41bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   89.95%   96.20%   +6.25%     
==========================================
  Files          19       19              
  Lines        1125     1160      +35     
  Branches       98       97       -1     
==========================================
+ Hits         1012     1116     +104     
+ Misses        113       44      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8452533 into main Nov 29, 2024
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-unreachable-code branch November 29, 2024 14:28
Copy link

🎉 This is included in version v0.5.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant