Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all Halogen examples to HalogenHooks #138

Closed
11 tasks done
milesfrain opened this issue Jul 7, 2020 · 5 comments · Fixed by #177
Closed
11 tasks done

Port all Halogen examples to HalogenHooks #138

milesfrain opened this issue Jul 7, 2020 · 5 comments · Fixed by #177
Assignees
Labels
recipe-request Requests for someone to build a recipe for their problem

Comments

@milesfrain
Copy link
Collaborator

milesfrain commented Jul 7, 2020

  • AceHalogenHooks AceEditorHalogen #120
  • BasicHalogenHooks
  • ComponentsHalogenHooks
  • ComponentsInputsHalogenHooks
  • ComponentsMultitypeHalogenHooks
  • DriverIoHalogenHooks
  • DriverRoutingHalogenHooks
  • DriverWebsocketsHalogenHooks
  • EffectsAffAjaxHalogenHooks
  • EffectsEffectRandomHalogenHooks
  • HigherOrderComponentsHalogenHooks
  • InterpretHalogenHooks
  • KeyboardInputHalogenHooks
  • LifecycleHalogenHooks

https://github.com/purescript-halogen/purescript-halogen/tree/master/examples

@milesfrain milesfrain added the recipe-request Requests for someone to build a recipe for their problem label Jul 7, 2020
@JordanMartinez
Copy link
Owner

I'm claiming this one next.

@JordanMartinez JordanMartinez self-assigned this Jul 10, 2020
@JordanMartinez
Copy link
Owner

ace isn't in the package set :-/

@JordanMartinez
Copy link
Owner

I'm not sure whether the following recipes should be implemented based on their readme's content. Thoughts?

  • effects-aff-ajax: "demonstrates how to make an AJAX request in a component eval function." Isn't this already shown via ImagePreviewsHalogenHooks?
  • effects-effect-random: "demonstrates how to use an Effect function in a component eval function." Isn't this already shown in various recipes here already? The example they use is generating a random number. We've already got recipes for doing that...
  • higher-order-components: "illustrates how to define and use a higher-order component". Hooks kind of make higher-order components pointless now because one can just define a hook (e.g. halogen-select) that can be embedded into another hook that is used to create a component

@JordanMartinez
Copy link
Owner

Aside from the above comment and #120, this issue is basically done.

@milesfrain
Copy link
Collaborator Author

milesfrain commented Jul 15, 2020

I'm not sure whether the following recipes should be implemented based on their readme's content. Thoughts?

Yes, that definitely looks like duplication.
It would be good to note this for readers attempting to find equivalent recipes to the examples. Not sure where to put this note. Maybe add something like this to the examples readme:

Hooks versions of the classic Halogen examples can be found in the PureScript Cookbook. Note that the following recipes were skipped due to redundancy: (add your summary of skipped recipes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe-request Requests for someone to build a recipe for their problem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants