Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.17 bug] Offline message not shown #376

Open
codeling opened this issue Nov 12, 2023 · 9 comments
Open

[2.0.17 bug] Offline message not shown #376

codeling opened this issue Nov 12, 2023 · 9 comments

Comments

@codeling
Copy link

codeling commented Nov 12, 2023

Steps to reproduce the issue

Switch a Joomla! page using the helix-ultimate temlate to offline in global configuration, set to show any message, custom or predefined (, or image).

Expected result

The offline message (and the image) will be shown along with the login form.

Actual result

Only the login form is shown, but not the message (nor the image); basically an empty page only with login fields.

System information (as much as possible)

Joomla 4.4, running on php 8.2 with mysql

Additional comments

The offline.php seems to be missing the placeholders for the offline image & messages. Inserting the ones from Joomla's templates/system/offline.php file makes the messages appear

@codeling codeling changed the title Offline message not shown [2.0.17 bug] Offline message not shown Nov 12, 2023
@Savama51
Copy link

Savama51 commented Nov 13, 2023

I confirm.
Tested under J4.4.0 and J5.0.0 ! fresh Joomla! install and Helix Ultimate 2.0.17.
Activating Offline mode in configuration will display only login form, no offline message, no logo...

We can have a logo displayed only if we add a logo to the "Coming Soon" setting, in Helix Ultimate Parameter.
The logo will then be displayed, even if Coming Soon is activated or not... not logic at all.
But no message.

I think the mode of operation of the offline page deserves to be rethought !

@mi-prakash
Copy link
Contributor

@codeling
For now If you want to set the site offline, use the coming soon page in the template settings > basic > coming soon
you can customise the page there

@joomleb
Copy link

joomleb commented May 27, 2024

@codeling @Savama51
Please, Can you replicate the issue with last Joomla 4.4.5 + Helix Ultimate 2.1.1 ?
Which version of PHP are you running?

@Savama51
Copy link

@codeling @Savama51 Please, Can you replicate the issue with last Joomla 4.4.5 + Helix Ultimate 2.1.1 ? Which version of PHP are you running?

Well no... The way the devs thought the offline page was to forget completely the offline content of base joomla! So nevermind what is mentionned in configuration file, the offline page will only display "Coming Soon" content.

We should have the choice between using base Joomla Offline or using Coming Soon feature.... but no, that's the way ^^

So I think there's no issue, only an operating logic specific to developers.

@codeling, this issue should be closed so.

@codeling
Copy link
Author

@joomleb I can verify that the behavior as I described it in my initial report still happens in exactly the same way.

@Savama51 I'm not sure I get what you are saying - that the behavior I describe is as intended by the helix-ultimate developers, and that the offline page functionality of base joomla actually shouldn't be used when helix-ultimate is installed?

@joomleb
Copy link

joomleb commented May 29, 2024

Hi guys
Please, @mi-prakash Can you answer @codeling "s question? What is Helix Ultimate's plan regarding the Joomla Offline feature ?

@Savama51
Copy link

@Savama51 I'm not sure I get what you are saying - that the behavior I describe is as intended by the helix-ultimate developers, and that the offline page functionality of base joomla actually shouldn't be used when helix-ultimate is installed?

Well that's the way, if HelixUltimate is the active template, offline infos in configuration file are not used...

The misunderstanding is in HU settings, we have to activate "Coming Soon" feature to be able to customise offline page, while if disabled, it uses anyway Coming Soon HU settings, not logical.

@joomleb
Copy link

joomleb commented May 30, 2024

Hi guys,
@Savama51 @codeling
What would be the most logical way for you?

@Savama51
Copy link

Hi guys, @Savama51 @codeling What would be the most logical way for you?

In my opinion, the tab setting should be named "Offline page" instead of "Coming soon".
And the "Enable Coming Soon" switch should not exist, as the offline page uses in all cases the following settings and totally forget the settings of offline's Joomla configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants