Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.18 bug] Twitter social icon #373

Open
joomleb opened this issue Nov 5, 2023 · 4 comments
Open

[2.0.18 bug] Twitter social icon #373

joomleb opened this issue Nov 5, 2023 · 4 comments

Comments

@joomleb
Copy link

joomleb commented Nov 5, 2023

Hi guys,
PHP 7.4.33 / 8.1.22 + Joomla 4.4.0 + HU 2.0.17 or 2.0.16 where I can read in the changelog: "Updated the Twitter X logo on social icons".
It was running on 2.0.15.

The Twitter social icon is shown in a "fixed way" and custom CSS on the social icons, like:
ul.social-icons > li {
font-size: 36px;
margin: 0 0.5rem;
}
Is not applied anymore to the Twitter X one.
I tried also changing ..templates/shaper_helixultimate/features/social.php file:

  • line. 50 twitter to x-twitter
  • line 66 fab to fa-brands
    but nothing change.

That should be the obvious way because in Helix Ultimate we can always set:

While you added the extra code (around line 126) where

  • you fixed width to 13.56px
  • you added top: -1.5px > it should be -3px to be vertically centered

Please, Can you confirm ? Is it the right way ?!?

@joomleb joomleb changed the title [2.0.17 bug] Twitter social icon is not shown [2.0.17 bug] Twitter social icon Nov 14, 2023
@imsherlocked
Copy link

hello @joomleb can you assign this issue to me, I am starting my open source contribution journey and it could be my first step in this journey.

@joomleb
Copy link
Author

joomleb commented Nov 19, 2023

@imsherlocked
nice to meet you!
Unfortunately I'm not part of the Helix Ultimate team, sorry.
@mi-prakash Please, Can you help @imsherlocked ?

I remain available...

@mi-prakash
Copy link
Contributor

mi-prakash commented Nov 22, 2023

@joomleb
For now we are using svg. in future we will use the font awesome icons when the font awesome 6 gets more popular.
To adjust anything u can use custom css.
thank you

@joomleb
Copy link
Author

joomleb commented Nov 22, 2023

Hi @mi-prakash
"...when the font awesome 6 gets more popula..." ?!? = FA6 is the default on Joomla 5 and with
HU 2.0.16 changelog you added "Joomla 5 compatibility"
HU 2.0.17 changelog you added "Font Awesome updated to 6.4.2"...

It should means that if I''m running on Joomla 4 (FA5) I set:
HU Advanced > Font settings > Enable Font Awesome: enabled

If I'm running Joomla 5 (FA6) I set:
HU Advanced > Font settings > Enable Font Awesome: disabled

That's all.
OR
Please, What is the "HU Advanced > Font settings > Enable Font Awesome" setting sense ?!?

@joomleb joomleb changed the title [2.0.17 bug] Twitter social icon [2.0.18 bug] Twitter social icon Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants