You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, sorry if my analysis is wrong. Thanks a lot for this clear and effective template, it really makes things a lot easier!
As far as I understood, content and content-ui entries under pages are injected automatically to the website we're on. Also we have the ability to inject the content-runtime if we click to the "Click to inject Content Script" button.
I'm wondering if both bundles are injecting their own node_modules into the current document, even when they're shared across. OR do they share the same React instance (or perhaps other common modules) somehow? If they do, I think I have missed it, and I'd be curious to see where it's being done. 🙂
If marking shared node_modules as externals or similar isn't practical, I think an alternative way to go could be causing a dynamic import to run in the content/content-ui scripts via chrome.runtime.onMessage or a similar mechanism, instead of appending another IIFE.
I think this could be a good feature request, if it isn't already covered. Thank you.
The text was updated successfully, but these errors were encountered:
Hi. Thanks for the nice comment. Each page context's bundle has its own files for the shared dependencies. I think we can try some things to fix this inefficiency, thanks for the great suggestion!
First of all, sorry if my analysis is wrong. Thanks a lot for this clear and effective template, it really makes things a lot easier!
As far as I understood,
content
andcontent-ui
entries underpages
are injected automatically to the website we're on. Also we have the ability to inject thecontent-runtime
if we click to the "Click to inject Content Script" button.I'm wondering if both bundles are injecting their own node_modules into the current document, even when they're shared across. OR do they share the same React instance (or perhaps other common modules) somehow? If they do, I think I have missed it, and I'd be curious to see where it's being done. 🙂
If marking shared node_modules as externals or similar isn't practical, I think an alternative way to go could be causing a dynamic import to run in the content/content-ui scripts via
chrome.runtime.onMessage
or a similar mechanism, instead of appending another IIFE.I think this could be a good feature request, if it isn't already covered. Thank you.
The text was updated successfully, but these errors were encountered: