Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3D ShapeCaster global_rotation #344

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Fix 3D ShapeCaster global_rotation #344

merged 1 commit into from
Mar 2, 2024

Conversation

ramon-oliveira
Copy link
Contributor

Objective

Fix 3D ShapeCaster global rotation. Currently, shape and parent rotation are adding its Quat instead of multiplying.

Solution

Multiply the rotations instead of adding.

Before and After

fix-shape-caster-rotation.mp4

@Jondolf Jondolf added bugfix A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests labels Mar 2, 2024
Jondolf
Jondolf approved these changes Mar 2, 2024
View reviewed changes
Copy link
Owner

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, thanks!

@Jondolf Jondolf merged commit 9c7d4de into Jondolf:main Mar 2, 2024
4 checks passed
@Jondolf Jondolf added C-Bug Something isn't working 3D Specific to three dimensions and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jondolf Jondolf Jondolf approved these changes

Assignees
No one assigned
Labels
3D Specific to three dimensions A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon-oliveira @Jondolf