Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on wasm-bindgen feature serde_json can cause circular dependency #52

Closed
bicarlsen opened this issue Mar 26, 2024 · 3 comments

Comments

@bicarlsen
Copy link
Collaborator

Currently the crate depends on wasm-bindgen = { version = "0.2.89", features = ["serde_json"] } which can cause a circular dependency as described in aHash and getrandom, and discussed further in wasm-bindgen.

I removed this feature dependency and played with the crate a bit, and everything still seems to work.

Reproduction

I ran into this issue when trying to incorporate SurrealDB into my Tauri app.

Including both surrealdb and tauri-sys caused the issue.

Patched branch

https://github.com/bicarlsen/tauri-sys/tree/fix/wasm_bindgen_serde

@emirror-de
Copy link

I ran into the same situation and can confirm that your patched branch works for me too. It would be awesome to get this integrated.

@Alex222222222222
Copy link

I also ran into the same issue when I enable the feature serde-serialize of wasm-bindgen.

Removed the feature also works for me.

@bicarlsen
Copy link
Collaborator Author

This should be resolved with PR #56, please raise another issue if you continue to run into problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants