You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This FR was inspired by being unable to send a token that was displayed in LW. The failure was caused by an incorrect decimal precision (defaulted to 4) in the TokenModel. I suggest that when generating a blockchain transaction (e.g. the send transfer) the precision should always be based on the contract itself rather than metadata provided by the app.
Nonetheless the app should have control over the precision displayed at various screens in LW, and the preferred display precision may not equal the contract precision.
Finally, while looking thru the code it appears that a few different algorithms are used to set display precision in different screens. At some point there may be benefit to refactoring display precision in a coherent way.
Describe the solution you'd like
Ensure that correct precision is used when generating blockchain transactions (e.g. send).
(Lower priority) Document a display precision policy and implement it.
Additional context
A working fix to use contract precision for send transactions is at 71f064f
for receive QR generator at 6d4dbaa
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
This FR was inspired by being unable to send a token that was displayed in LW. The failure was caused by an incorrect decimal precision (defaulted to 4) in the TokenModel. I suggest that when generating a blockchain transaction (e.g. the send transfer) the precision should always be based on the contract itself rather than metadata provided by the app.
Nonetheless the app should have control over the precision displayed at various screens in LW, and the preferred display precision may not equal the contract precision.
Finally, while looking thru the code it appears that a few different algorithms are used to set display precision in different screens. At some point there may be benefit to refactoring display precision in a coherent way.
Describe the solution you'd like
Additional context
A working fix to use contract precision for send transactions is at
71f064f
for receive QR generator at
6d4dbaa
The text was updated successfully, but these errors were encountered: