Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor colonyFundsClaimed query #93

Open
willm30 opened this issue Jun 23, 2023 · 0 comments
Open

Refactor colonyFundsClaimed query #93

willm30 opened this issue Jun 23, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@willm30
Copy link
Contributor

willm30 commented Jun 23, 2023

Using the list version of ColonyFundsClaimed query could be improved here. This will list all ColonyFundsClaims in the db, and only apply filtering for colony and token once the query returns. If we have more than 100 items in the db (the default limit), we may not receive the results we're expecting.

We should be able to query the colony directly and get claims from there, since they're connected in the schema.

listCol

@willm30 willm30 self-assigned this Jun 23, 2023
@willm30 willm30 added the good first issue Good for newcomers label Jul 5, 2023
@willm30 willm30 removed their assignment Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant