Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks with results for new PCollections data structures. #1

Open
BomBardyGamer opened this issue Oct 19, 2022 · 1 comment

Comments

@BomBardyGamer
Copy link

BomBardyGamer commented Oct 19, 2022

This is a great benchmark, and is very useful in showing the relative performance of persistent data structures when isolated from external factors. However, I noticed that the benchmarks are missing a PCollections equivalent for the linked set/map and the ordered set/map. I believe this is because the benchmark was made before these data structures were added to PCollections, so I wonder if it would be worth adding some benchmarks for these new data structures and getting some new results.

Specifically, the new structures are:

  • Linked Set: OrderedPSet - doesn't seem to have a linked implementation, but the documentation specifies that the implementations are equivalent, and it's the entry order we're after here
  • Linked Map: OrderedPMap - doesn't seem to have a linked implementation, but the documentation specifies that the implementations are equivalent, and it's the entry order we're after here
  • Sorted Set: TreePSet
  • Sorted Map: TreePMap

I'd be up to re-run the new benchmarks and provide you with some new results.

@JohnnyJayJay
Copy link
Owner

Thanks for the heads up! Yeah, that should be added. I'll see when I have time to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants