Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTest uses syntex_syntax which doesn't support raw identifiers. #6

Open
ghost opened this issue Apr 30, 2020 · 2 comments
Open

CTest uses syntex_syntax which doesn't support raw identifiers. #6

ghost opened this issue Apr 30, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Apr 30, 2020

CTest fails on code that uses raw identifiers like r#type. Currently libc translation of structs that have a type field in c are translated as type_ because of that.

If CTest would support raw identifiers we could accurately use type as a field name in rust too.
@JohnTitor
Copy link
Owner

JohnTitor commented Aug 21, 2020 •
edited
Loading

I'd say it would be quite hard as syntex is quite old. So we should:

  1. Find the possible oldest version that supports the raw identifiers.
  2. Update syntex (note that we now use https://github.com/JohnTitor/garando instead to remove some outdated dependencies)
  3. Make sure that all the things aren't broken.

@JohnTitor
Copy link
Owner

Maybe we could use syn crate alternatively but it'd be a big change.

@JohnTitor JohnTitor linked a pull request May 11, 2022 that will close this issue
Remove the use of mem::zeroed() from generated code #35
Merged
@JohnTitor JohnTitor removed a link to a pull request May 11, 2022
Remove the use of mem::zeroed() from generated code #35
Merged
@JohnTitor JohnTitor mentioned this issue May 28, 2022
Open
@JohnTitor JohnTitor added bug Something isn't working help wanted Extra attention is needed labels Aug 8, 2022
@JohnTitor JohnTitor mentioned this issue Feb 3, 2023
Open
yodaldevoid added a commit to yodaldevoid/ssh2-rs that referenced this issue Nov 5, 2024
@yodaldevoid
systest: Switch to ctest2
1943d20 
gnzlbg/ctest#70

ctest2 is not perfect (see JohnTitor/ctest2#6
and other issues), but it is better than nothing and works for now.
yodaldevoid added a commit to alexcrichton/ssh2-rs that referenced this issue Nov 5, 2024
@yodaldevoid
systest: Switch to ctest2
a6879b0 
gnzlbg/ctest#70

ctest2 is not perfect (see JohnTitor/ctest2#6
and other issues), but it is better than nothing and works for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohnTitor