Add error message to DatabaseError output #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks like a nice little improvement to me. CC @cgivre |
|
Ping @cgivre. |
jnturton
pushed a commit
to jnturton/sqlalchemy-drill
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drill 1.19 omits the error message in REST API by default, which is overwritable by setting
http.rest.errors.verbosetotrue. Some non-technical users may benefit from having an error message in Superset UI in case there is a database error or their SQL query is corrupted, which this PR implements. If no error message is provided, it is also useful to know how to overwrite that behavior as it is not easily searchable online.