Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substitute_in_query method doesn't working fine #86

Open
Maegor opened this issue Jun 6, 2023 · 0 comments
Open

substitute_in_query method doesn't working fine #86

Maegor opened this issue Jun 6, 2023 · 0 comments

Comments

@Maegor
Copy link

Maegor commented Jun 6, 2023

The "substitute_in_query" method should substitute parameters in SQL queries but it does not.
The problem seems to be in line 36 of the _drillapi.py file:
"query.replace('?', param, 1)" . The replace method returns a new string, it does not modify the original one. This causes the method to return the original query, without modifying the original string.

sqlalchemy-drill version is 1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant