You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary of the problem: navbarMenu tabs can be highlighted by a guide when using the most recent cicerone release on CRAN however the tab panel switch does not work. If I use the most recent dev release, switching between tabs in tabsetPanel works fine however navbarMenu tabs cannot be highlighted anymore.
I have the following minimal shiny app as an example:
library(shiny)
ui <- fluidPage(
use_cicerone(),
navbarPage('App Title',
tabPanel('Plot',
tabsetPanel(id = 'tabz',
tabPanel('tab1', h2('show plot of tab 1 here', id = 'plot')),
tabPanel('tab2', h2('show plot of tab 2 here', id = 'plottab2')))),
navbarMenu('More',
tabPanel('Summary'),
hr(),
'Section header',
tabPanel('Table')
)
)
)
server <- function(input, output){
# initialise then start the guide
guide$init()$start()
}
shinyApp(ui, server)
When I use the most recent release from cicerone then the tab change would not work:
library(cicerone)
guide <- Cicerone$
new()$
step(
el = 'plot',
title = 'Text Input',
description = 'This is where you enter the text you want to print.'
)$
step(
'plottab2',
'Plot on tab 2',
'Here is a plot on tab 2',
tab = 'tab2',
tab_id = 'tabz'
)
but highlighting the first level of a navbarMenu in a guide works. However this does not work for the subtab:
library(cicerone)
guide <- Cicerone$
new()$
step(
'[data-value="More"]',
'More tab options',
'Select one of the subtabs',
is_id = FALSE
)$
step(
'[data-value="Summary"]',
'Summary tab',
'Select one of the subtabs',
is_id = FALSE
)
When I use the most recent dev release of cicerone switching tabs of a tabsetPanel works perfectly fine:
library(cicerone)
guide <- Cicerone$
new()$
step(
el = 'plot',
title = 'Text Input',
description = 'This is where you enter the text you want to print.'
)$
step(
'plottab2',
'Plot on tab 2',
'Here is a plot on tab 2',
tab = 'tab2',
tab_id = 'tabz'
)
however even just guiding to the top layer of a navbarMenu causes the app to crash
library(cicerone)
guide <- Cicerone$
new()$
step(
el = 'plot',
title = 'Text Input',
description = 'This is where you enter the text you want to print.'
)$
step(
'plottab2',
'Plot on tab 2',
'Here is a plot on tab 2',
tab = 'tab2',
tab_id = 'tabz'
)$
step(
'[data-value="More"]',
'More tab options',
'Select one of the subtabs',
is_id = FALSE
)$
step(
'[data-value="Summary"]',
'Summary tab',
'Select one of the subtabs',
is_id = FALSE
)
The text was updated successfully, but these errors were encountered:
Was this fixed? I'm having a similar issue, using cicerone 1.0.4 and the example in the documentation isn't working
`library(cicerone)
guide <- Cicerone$
new()$
step(
el = "plot",
title = "Text Input",
description = "This is where you enter the text you want to print."
)$
step(
"summary",
"Send the Text",
"Send the text to the server for printing",
tab = "summary_tab",
tab_id = "tabz"
)
library(shiny)
ui <- fluidPage(
use_cicerone(), # include dependencies
h1("tabs"),
tabsetPanel(
id = "tabz",
tabPanel("plot_tab", h2("show plot here", id = "plot")),
tabPanel("summary_tab", h2("show summary here", id = "summary"))
)
)
Summary of the problem:
navbarMenu
tabs can be highlighted by a guide when using the most recent cicerone release on CRAN however the tab panel switch does not work. If I use the most recent dev release, switching between tabs intabsetPanel
works fine howevernavbarMenu
tabs cannot be highlighted anymore.I have the following minimal shiny app as an example:
When I use the most recent release from
cicerone
then the tab change would not work:but highlighting the first level of a
navbarMenu
in a guide works. However this does not work for the subtab:When I use the most recent dev release of
cicerone
switching tabs of a tabsetPanel works perfectly fine:however even just guiding to the top layer of a
navbarMenu
causes the app to crashThe text was updated successfully, but these errors were encountered: