Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll 4/4: W4 and I9 buttons must show reasons for red color #173

Open
ghost opened this issue Sep 26, 2022 · 0 comments
Open

Payroll 4/4: W4 and I9 buttons must show reasons for red color #173

ghost opened this issue Sep 26, 2022 · 0 comments
Labels
🪲 bug Something isn't working ⭐ P2 Second priority

Comments

@ghost
Copy link

ghost commented Sep 26, 2022

W4 and I9 buttons must show reasons for red color

Issue:

To replicate this issue, you need to enter the main JobCore account and ask your supervisor for the credentials to enter.

Once you enter the main account, follow these steps:

  • Go to the "Payroll" page; there, you will see 4 black buttons on the right side of the screen. one of them says "Search by Timesheet."
  • If you click this button, you will see a list of available timesheets by payroll periods. Feel free to select any of them.
  • Once you select one of them, you will see a block of information per employee.

Here comes the problem, if either the W4 or I9 buttons are red, it means that the document is missing or has been rejected. If you click either of them, nothing gets displayed in response, the page just hangs in there.

However, the user should be able to see a message with a specific reason why (the document may be missing entirely, or the photo quality may be too low, requiring a re-submission).

For reference, the code for this issue exists between lines 456 and 590 of /workspace/employer-web-client/src/js/components/applicant-card/EmployeeExtendedCard.jsx

issue 4

Solution:

A developer should make it so that the buttons display a message with a specific reason if they are red and get clicked.

Solution Steps:

  1. Investigate where the return value is once the buttons are clicked, and implement conditions to render each reason.
  2. Once finished, run all the tests provided in the repo to make sure that your integration was successful
  3. Create a pull request so that your code can be evaluated by the Lead Developer before deployment.
  4. Keep an eye out for any new bugs that arise after the change is deployed to the code.
@ghost ghost added 🪲 bug Something isn't working ⭐ P2 Second priority labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working ⭐ P2 Second priority
Projects
None yet
Development

No branches or pull requests

0 participants