Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination error for "verified" employees #169

Open
ghost opened this issue Sep 26, 2022 · 0 comments
Open

Pagination error for "verified" employees #169

ghost opened this issue Sep 26, 2022 · 0 comments
Labels
🪲 bug Something isn't working ⭐ P2 Second priority

Comments

@ghost
Copy link

ghost commented Sep 26, 2022

Pagination error for "verified" employees

Issue:

On the "Talent Search" page, you can see three main buttons to filter employee results: "Rejected, "Verified", and "Unverified."
If you click the "Verified" button, you will see limited results (maybe 1- 5 results). This is incorrect since you should be able to see a long list.

If you start clicking the "pagination" buttons at the bottom, you will see that the results start to expand, almost as if they were hidden at first, and you unlock more with each button click.

The verified tab should show a long list of employees, without the need to start clicking the pagination buttons. The buttons should only help the user to see more results that don't fit the initial page. Right now, they are needed to fill the initial page in the first place.

For reference, the code for this issue exists between lines 244 and 419 of /workspace/employer-web-client/src/js/views/talents.js.

issue 2

Solution:

A developer should make it so that the initial page of the "Verified" tab shows as many results as possible. Then, make it so that the buttons show extra results that didn't fit on the initial page.

Solution Steps:

  1. Investigate how the initial page displays the list of employees, and what filters is it using.
  2. Investigate how the pagination buttons are being triggered and how are they connected to the list being displayed.
  3. You can use CodeSandbox to replicate some data and test the pagination issue in an isolated manner.
  4. Once finished, run all the tests provided in the repo to make sure that your integration was successful
  5. Create a pull request so that your code can be evaluated by the Lead Developer before deployment.
  6. Keep an eye out for any new bugs that arise after the change is deployed to the code.
@ghost ghost added 🪲 bug Something isn't working ⭐ P2 Second priority labels Sep 26, 2022
@ghost ghost changed the title Bug: Pagination error for "verified" employees Pagination error for "verified" employees Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working ⭐ P2 Second priority
Projects
None yet
Development

No branches or pull requests

0 participants