Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test results of the PSGTR model are incorrect #60

Closed
zishengzheqiang opened this issue Sep 22, 2022 · 5 comments
Closed

The test results of the PSGTR model are incorrect #60

zishengzheqiang opened this issue Sep 22, 2022 · 5 comments
Assignees
Labels
competition Issues about The PSG Challenge

Comments

@zishengzheqiang
Copy link

I use the epoch_60.pth of PSGTR model to run test scripts
1663815778256

I change the detection_method='bbox'
1663815965952

This is the result in the log file you gave
1663816185885
There is a big difference between them,What is the problem behind this phenomenon?

@Jingkang50
Copy link
Owner

#51
Thanks for your question. You might refer to this discussion.

@Jingkang50
Copy link
Owner

In short, you might need to change

OpenPSG/openpsg/models/frameworks/psgtr.py

Line 16 in a0e5c8f

def triplet2Result(triplets, use_mask, eval_pan_rels=True):

to eval_pan_rels=False.

@zishengzheqiang
Copy link
Author

Thanks for your detailed explanation! I set eval_pan_rels=False and R@20 is higher than before.
But the competition needs to submit a panseg png file, we should set eval_pan_rels=True, so the R@20 is low, Is it possible to conclude that the one-stage algorithm is worse than the two-stage algorithm?

In short, you might need to change

OpenPSG/openpsg/models/frameworks/psgtr.py

Line 16 in a0e5c8f

def triplet2Result(triplets, use_mask, eval_pan_rels=True):

to eval_pan_rels=False.

@Jingkang50
Copy link
Owner

I would not conclude in this way, as mean recall is the metric the community cares more. Also, we turn on eval_pan_rel for easy submission of the competition, but the model who has good performance with eval_pan_rel off can also greatly support the downstream task. For researchers who follows PSG but not only for competition, we also recommend them to explore a better solution when eval_pan_rel off.

@Jingkang50 Jingkang50 self-assigned this Sep 22, 2022
@Jingkang50 Jingkang50 added the competition Issues about The PSG Challenge label Sep 22, 2022
@zishengzheqiang
Copy link
Author

I get it, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
competition Issues about The PSG Challenge
Projects
None yet
Development

No branches or pull requests

2 participants