Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this work be combined with multi-resolution hash coding? #4

Open
BCL123456-BAL opened this issue Apr 15, 2023 · 4 comments
Open

Comments

@BCL123456-BAL
Copy link

It's a great job!
But I noticed that your results were obtained on 4 NVIDIA A40 GPUs.
This is very counterintuitive, less mirrors of the training view will increase the burden of training.
Can it be combined with hash multi-resolution coding to speed up training time and reduce GPU burden?

Best wish
Chenglong

@SophusDavid
Copy link

I try to reproduce this work(mainly freq_mask) on nerfstudio and here is my code https://github.com/SophusDavid/FreeNeRF_NeRFStudio
But actually the performance is bad.Any advice is welcomed!

@Jiawei-Yang
Copy link
Owner

Hi there,

Thanks for your attention to our work! We do think combining the idea of FreeNeRF with multi-grid / hash-grid-based methods will be a promising direction for future work!

@SophusDavid Thank you for your initial implementation! It would be great if you can further elaborate on the bad performance, e.g., what the bad results look like. Did you try to monitor the change of frequency mask as a sanity check? I'm currently out of bandwidth to go through the entire implementation, but I will definitely do so when I'm available!

@SophusDavid
Copy link

SophusDavid commented Apr 21, 2023

Hi there,

Thanks for your attention to our work! We do think combining the idea of FreeNeRF with multi-grid / hash-grid-based methods will be a promising direction for future work!

@SophusDavid Thank you for your initial implementation! It would be great if you can further elaborate on the bad performance, e.g., what the bad results look like. Did you try to monitor the change of frequency mask as a sanity check? I'm currently out of bandwidth to go through the entire implementation, but I will definitely do so when I'm available!

Sorry,that was a mistake . I just checked my code and there are some bugs. When I fixed them,the result seems similar to the paper.I'm going to test metrics tomorrow or the day after tomorrow.By the way ,can you tell me which images you use for training? I tried to find in the paper but failed.Thanks for your awesome work again :)

@gucka28
Copy link

gucka28 commented May 4, 2023

Hello, @Jiawei-Yang

Thank you for sharing your work!
Could you share the result of your implementation on benchmark dataset (LLFF or Blender dataset)?
Does the same frequency masking hyper-parameter works good in Hash-grid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants