Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): don't eat not allowed tags #58

Merged
merged 4 commits into from
Apr 12, 2020

Conversation

JiLiZART
Copy link
Owner

Fixes #54

@JiLiZART JiLiZART force-pushed the bugfix/54-invalid-tags-eaten branch from dd7e2bb to 05a5862 Compare April 12, 2020 14:52
@codecov-io
Copy link

Codecov Report

Merging #58 into master will decrease coverage by 0.32%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   93.33%   93.00%   -0.33%     
==========================================
  Files          15       15              
  Lines         510      529      +19     
  Branches      116      120       +4     
==========================================
+ Hits          476      492      +16     
- Misses         28       30       +2     
- Partials        6        7       +1     
Impacted Files Coverage Δ
packages/bbob-plugin-helper/src/TagNode.js 78.57% <94.11%> (+17.03%) ⬆️
packages/bbob-parser/src/parse.js 94.25% <100.00%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28f19e...d1a07b6. Read the comment docs.

@JiLiZART JiLiZART merged commit a16b9f7 into master Apr 12, 2020
@JiLiZART JiLiZART deleted the bugfix/54-invalid-tags-eaten branch April 12, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would-be attributes on invalid tags being eaten during parse
2 participants