Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bbob-react): remove unique "key" prop warning #30

Merged
merged 2 commits into from
Jun 29, 2019

Conversation

skipjack
Copy link
Contributor

When using @bbob/reacts <BBCode> component, the following error is thrown if this change is not included...

Warning: Each child in a list should have a unique "key" prop.

Mentioned in #28

When using `@bbob/react`s `<BBCode>` component, the following error is thrown
if this change is not included...

```
Warning: Each child in a list should have a unique "key" prop.
```

Mentioned in JiLiZART#28
@skipjack skipjack mentioned this pull request Jun 28, 2019
7 tasks
@codecov-io
Copy link

codecov-io commented Jun 28, 2019

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          15       15           
  Lines         477      477           
  Branches      102      102           
=======================================
  Hits          448      448           
  Misses         23       23           
  Partials        6        6
Impacted Files Coverage Δ
packages/bbob-react/src/render.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac6358...9fd9345. Read the comment docs.

@JiLiZART JiLiZART changed the title fix(bbob-react): fix unique "key" prop warning fix(bbob-react): remove unique "key" prop warning Jun 29, 2019
@JiLiZART JiLiZART merged commit 3d5c1f1 into JiLiZART:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants