fix(plugin-helper): lowercase all tag names so presets pick them up #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBCode is usually specified as lower case and all the presets define lowercase tags so capitalized tags like `[B]` or `[QUOTE]` won't be handle properly. This should fix that because the parser uses this constructor/class before any presets are run.
|
Good job! Seems some tests in https://github.com/JiLiZART/bbob/blob/master/packages/bbob-parser/test/parse.test.js needs to be fixed. |
|
Sorry, I close this PR cuz of #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BBCode is usually specified as lower case and all the presets define lowercase
tags so capitalized tags like
[B]or[QUOTE]won't be handle properly. Thisshould fix that because the parser uses this constructor/class before any presets
are run.
See #28 for more details.