Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Jetbrains.Fantomas #4

Closed
nojaf opened this issue Nov 22, 2017 · 2 comments
Closed

Question: Jetbrains.Fantomas #4

nojaf opened this issue Nov 22, 2017 · 2 comments

Comments

@nojaf
Copy link
Contributor

nojaf commented Nov 22, 2017

I just found this on nuget and was wondering if it can be used outside of Rider?
A while ago I read that fantomas might end up in FSharp.Compiler.Service.
So now I'm curious where the team is heading with the usage of Fantomas. Will you eventually swap to the FCS version once it is stable?

On a side note is the formatting of F# code already available in Rider 2017.2?

@auduchinok
Copy link
Collaborator

auduchinok commented Nov 22, 2017

@nojaf It is a version built against latest FCS, nothing is added, something not needed in our case is cut. This package should have been unlisted in NuGet, although technically it could be used outside Rider if a newer FCS is needed (e.g. for using FSharpParsingOptions instead of FSharpProjectOptions). A better approach would be to open a PR incorporating changes needed for the newer FCS in the Fantomas repo and ask its maintainers to publish a newer build to NuGet. I'm going to do it at some point if no one else does it before.
We'll definitely move to the Fantomas bundled in FCS once it's integrated (see a newer discussion here), but looking at the discussion I doubt it'll happen anytime soon.

As of Rider 2017.2.1 selection formatting was disabled but should work for file level in cases where Fantomas is able to reformat it.

@nojaf
Copy link
Contributor Author

nojaf commented Nov 22, 2017

Thanks for the clarification. I tested the formatting on a file instead of selection, it indeed works.

@nojaf nojaf closed this as completed Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants