Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginVerification: "No IntelliJ Platform dependency found" when upgrading to 2.1.0 #1784

Closed
etienne02 opened this issue Oct 3, 2024 · 3 comments
Labels
Milestone

Comments

@etienne02
Copy link

What happened?

When dependabot tried to upgrade the plugin to 2.1.0 the cicd failed with error No IntelliJ Platform dependency found
After investigation, I found that this is caused by the dependencies block being declared after the intellijPlatform block. If I move the dependencies block before the intellijPlatform one, the error disapear.

Note that for plugin version 2.0.x, the current setup properly works.

I would like to be able to upgrade without having to change the order, to keep things like it is currently (and if it’s not possible, please document that blocks order is important).

Relevant log output or stack trace

No response

Steps to reproduce

Take a plugin, enable plugin verification with ides { recommended() }, put the dependencies block with the IDE platform selection (type and version) after the intellijPlatform block.

Gradle IntelliJ Plugin version

2.1.0

Gradle version

8.10

Operating System

Linux

Link to build, i.e. failing GitHub Action job

https://github.com/intellij-dlanguage/intellij-dlanguage/actions/runs/11050808276/job/30699362994?pr=1017

@etienne02 etienne02 added the bug label Oct 3, 2024
@AlexanderBartash
Copy link
Contributor

I actually noticed this in code and thought it is weird too, so I change the order https://github.com/JetBrains/intellij-platform-gradle-plugin/pull/1782/files#diff-d14c7b904d5da6fc68880bd99c79d830333db81daa3c96e633e289c689d00a81R319

Maybe it is going to help.

@BoD
Copy link

BoD commented Oct 4, 2024

Had the same issue - can confirm the workaround works.

BoD added a commit to apollographql/apollo-kotlin that referenced this issue Oct 4, 2024
@hsz hsz added this to the next milestone Oct 30, 2024
@hsz
Copy link
Member

hsz commented Oct 30, 2024

Fixed with 1f649d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants