Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update skiko to 0.8.11 #1486

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Update skiko to 0.8.11 #1486

merged 4 commits into from
Aug 12, 2024

Conversation

eymar
Copy link
Member

@eymar eymar commented Aug 5, 2024 •
edited
Loading

It's based on skia m126
Skiko update PR: JetBrains/skiko#969

Testing

  • The demo runs on all platforms
  • The tests passed

This should be tested by QA

Release Notes

Highlights - Multiple Platforms

  • Skiko version was updated to 0.8.11 (It is based on skia m126 release)

@eymar
Update skiko to 0.8.10.1
b098298 
It's based in skia m126
@eymar eymar mentioned this pull request Aug 5, 2024
Merged
@igordmn
Copy link
Collaborator

igordmn commented Aug 5, 2024 •
edited
Loading

For the future:

  • hotfix version should be reserved only for real hot fix updates. A Skia update should increase either the third, or better the second number.
  • if we need a dev build, we need to build 0.8.10+my-build. Everything after + is ignored by Gradle order comparator. but we need to modify Skiko Gradle scripts a little.

@eymar
Copy link
Member Author

eymar commented Aug 6, 2024

Compose tests passed

@eymar eymar changed the title Update skiko to 0.8.10.1 Update skiko to 0.8.11 Aug 12, 2024
MatkovIvan
MatkovIvan approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be mentioned in a changelog (please restore this part of the description template)

@eymar eymar merged commit 0d891b8 into jb-main Aug 12, 2024
6 checks passed
@eymar eymar deleted the ok/upd_skiko_0.8.10.1 branch August 12, 2024 10:03
mazunin-v-jb pushed a commit that referenced this pull request Aug 14, 2024
@eymar @mazunin-v-jb
Update skiko to 0.8.11 (#1486)
4ec5441 
It's based on skia m126
Skiko update PR: JetBrains/skiko#969

## Testing
<!-- Optional -->
- The demo runs on all platforms
- The tests passed

<!-- Optional -->
This should be tested by QA

## Release Notes
### Highlights - Multiple Platforms
- Skiko version was updated to 0.8.11 (It is based on skia m126 release)
@igordmn
Copy link
Collaborator

igordmn commented Aug 16, 2024 •
edited
Loading

It should be mentioned in a changelog (please restore this part of the description template)

Do we really need it? Nothing is changed for users.

If we decide to keep it, I wouldn't mention it is a Highlight, and don't mention Skiko, only Skia

@MatkovIvan
Copy link
Member

skia + moving to features block lgtm

@igordmn igordmn mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

@MatkovIvan MatkovIvan MatkovIvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eymar @igordmn @MatkovIvan