Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpSampling layers #143

Closed
6 tasks
mkaze opened this issue Jun 19, 2021 · 2 comments · Fixed by #146
Closed
6 tasks

Add UpSampling layers #143

mkaze opened this issue Jun 19, 2021 · 2 comments · Fixed by #146
Assignees
Labels
good second issue Good for advanced contributors
Milestone

Comments

@mkaze
Copy link
Contributor

mkaze commented Jun 19, 2021

Currently, the support for UpSampling layers is missing and it would be great if we could add support for these layers as well. The desired PR addressing this issue should include:

  • Implementation of layers classes named as UpSampling1D, UpSampling2D and UpSampling3D.
  • Common hierarchy of all UpSampling layers with abstract class with the common functionality
  • Documentation of layer and all non-private methods
  • JUnit tests in api module
  • Support for export of layers to JSON (see ModelSaver.kt)
  • Support for import of layers from JSON (see ModelLoader.kt)

Also, if needed, you can take a look at Keras documentation for these layers: UpSampling1D, UpSamplling2D and UpSampling3D.

NOTE: for the moment, there is no need to add support for "data format" (i.e. channels last vs. channels first) in your PR; you can simply assume the channels are always in the last dimension.

@mkaze
Copy link
Contributor Author

mkaze commented Jun 21, 2021

I'll take this one.

@zaleslaw zaleslaw added the good second issue Good for advanced contributors label Jun 21, 2021
@zaleslaw
Copy link
Collaborator

It's a very interesting bunch of layers, @mkaze good luck with that, it includes a lot of functionality in the Keras, we should try to avoid repeating all of it, ignoring things not related to the current state of the KotlinDL

@zaleslaw zaleslaw added this to the 0.3 milestone Jun 21, 2021
@mkaze mkaze mentioned this issue Jun 21, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good second issue Good for advanced contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants