Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you feel about... ? #32

Open
jonstorer opened this issue May 29, 2013 · 1 comment
Open

How do you feel about... ? #32

jonstorer opened this issue May 29, 2013 · 1 comment

Comments

@jonstorer
Copy link
Contributor

Jerry,

How do you feel about extending other object's and their prototypes? Specifically, I would love to have:

1.month.from_now.getMonthName();
// or
1.month.from_now.MonthName();
// since you can't really set the month name

How do you feel about that? I think it would be a good approach to help with the #addDays issues I've seen added in the past few months.

Thoughts?

@JerrySievert
Copy link
Owner

Hm. for some reason i thought that i had answered this a while back, maybe i didn't hit the "comment' button - sorry!

i think it would be awesome, but i already feel bad about monkey-patching Date, going so far as to patch Number as well might be a little much. it might be interesting to have it as an add-on, but i don't think i'd feel good about it being in the core module.

in return, how do you feel about addon modules? i think there's a lot of room for something like this in 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants