Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate rewardPct for stock LPs #1482

Closed
dnamurphy opened this issue Jan 31, 2022 · 8 comments · Fixed by #1647 · May be fixed by JellyfishSDK/whale#869
Closed

Populate rewardPct for stock LPs #1482

dnamurphy opened this issue Jan 31, 2022 · 8 comments · Fixed by #1647 · May be fixed by JellyfishSDK/whale#869
Assignees
@canonbrother @ivan-zynesis
Labels
apps/whale-api area/apps kind/feature New feature request priority/urgent-now Urgent fix, as fast as possible triage/accepted Triage has been accepted

Comments

@dnamurphy
Copy link

What would you like to be added:

The percentage distribution of block rewards for stock (ie. DUSD-based) liquidity pools. This should be recorded in the rewardPct attribute under the poolpairs access point.

Why is this needed:

The attributes of these assets should mirror the DFI-based LPs (e.g. ETH-DFI). There is no clear way under the API to extract the reward distribution of the stock LPs, whereas there is with DFI-based pools. Given the former are subject to change, it is very useful to have the correct distribution available.
@dnamurphy dnamurphy added the kind/feature New feature request label Jan 31, 2022
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Jan 31, 2022
@defichain-bot
Copy link
Contributor

@dnamurphy: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot
Copy link
Contributor

@dnamurphy: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/area Needs area label(s) label Jan 31, 2022
@dnamurphy
Copy link
Author

/area module-api

@defichain-bot defichain-bot added area/module-api and removed needs/area Needs area label(s) labels Jan 31, 2022
@fuxingloh
Copy link
Contributor

/triage accepted

Related to #1179

@defichain-bot defichain-bot added triage/accepted Triage has been accepted and removed needs/triage Waiting for triage to be accepted labels Mar 15, 2022
@ivan-zynesis ivan-zynesis mentioned this issue Mar 18, 2022
Closed
@ivan-zynesis ivan-zynesis self-assigned this Mar 18, 2022
@ivan-zynesis ivan-zynesis mentioned this issue Mar 21, 2022
Open
@fuxingloh fuxingloh added the priority/important-soon Will be important soon label May 30, 2022
@fuxingloh fuxingloh transferred this issue from JellyfishSDK/whale May 30, 2022
@jellyfishsdk-bot
Copy link
Contributor

@dnamurphy: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@jellyfishsdk-bot jellyfishsdk-bot added needs/triage Waiting for triage to be accepted needs/kind Needs kind label needs/area Needs area label(s) labels May 30, 2022
@jellyfishsdk-bot
Copy link
Contributor

@dnamurphy: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@fuxingloh fuxingloh added area/apps and removed needs/kind Needs kind label needs/triage Waiting for triage to be accepted needs/area Needs area label(s) area/module-api labels May 30, 2022
@fuxingloh
Copy link
Contributor

JellyfishSDK/whale#869 (comment)
JellyfishSDK/whale#869 (comment)

/assign @canonbrother do you mind working on this?

@fuxingloh
Copy link
Contributor

/priority urgent-now
/apps whale-api

@jellyfishsdk-bot jellyfishsdk-bot added priority/urgent-now Urgent fix, as fast as possible and removed priority/important-soon Will be important soon labels Jul 18, 2022
@canonbrother canonbrother mentioned this issue Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@canonbrother canonbrother

@ivan-zynesis ivan-zynesis

Labels
apps/whale-api area/apps kind/feature New feature request priority/urgent-now Urgent fix, as fast as possible triage/accepted Triage has been accepted
Projects
None yet
Milestone
No milestone
6 participants
@dnamurphy @fuxingloh @canonbrother @ivan-zynesis @defichain-bot @jellyfishsdk-bot