Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldKeyDownEventCreateNewOption should hook on KeyPress instead of KeyDown #1934

Closed
rpominov opened this issue Aug 18, 2017 · 1 comment
Closed

Comments

@rpominov
Copy link

rpominov commented Aug 18, 2017

event.keyCode has different meaning on KeyDown and KeyPress. On KeyDown it refers to code of actual physical key on keyboard, while on KeyPress it refers to a character that will be typed. See https://stackoverflow.com/a/11030750

Because currently it's hooked to KeyDown event, it's impossible to enter other characters that share physical key with the comma.

For example on the following keyboard with the default shouldKeyDownEventCreateNewOption I'm unable to enter "<" and "Б". Also the default callback doesn't handle comma key in the number row. And I can't add it either because I would need to sacrifice "6" and "^".

image

See also #345

@bladey
Copy link
Contributor

bladey commented May 27, 2020

Hello -

In an effort to sustain the react-select project going forward, we're closing old issues / pull requests.

We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our limited efforts to maintain the latest version.

If you feel this issue / pull request is still relevant and you'd like us to review it, please leave a comment and we'll do our best to get back to you.

@bladey bladey closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants