Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS selectors should be lowercase #1174

Closed
rantler opened this issue Aug 26, 2016 · 2 comments
Closed

CSS selectors should be lowercase #1174

rantler opened this issue Aug 26, 2016 · 2 comments

Comments

@rantler
Copy link

rantler commented Aug 26, 2016

Using mixed case CSS selectors can lead to confusion, bugs, and often conflicts with existing coding style guides. Please consider renaming the CSS selectors in this project to use lowercase exclusively.

@Abzoozy
Copy link

Abzoozy commented Sep 3, 2016

I totally agree, and it actually happened in our current project where my colleague forgot to add capital S for select and hence the css rule wasn't applied in our project

@bvaughn
Copy link
Collaborator

bvaughn commented Sep 4, 2016

I agree that case-insensitive selectors might be a bit more robust. Unfortunately this kind of change can't really be made due to the fact that it would either break backwards compatibility or require setting redundant classnames to support existing styles/users.

This seems like a good thing to revisit down the road for version 2.x though. I'm going to tag it as such but close it for now. I think time is too limited at the moment and 1.x is already ambitious enough.

Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants