Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata is not stored on a per variant basis #79

Open
JeanChristopheMorinPerso opened this issue Dec 10, 2023 · 0 comments
Open

Metadata is not stored on a per variant basis #79

JeanChristopheMorinPerso opened this issue Dec 10, 2023 · 0 comments

Comments

@JeanChristopheMorinPerso
Copy link
Owner

JeanChristopheMorinPerso commented Dec 10, 2023

I recently realized that the metadata we stored in the package definition is not done on a per variable basis. This is extremely problematic because rez-pip's installs wheels, which can have different metadata for a given version. The first thing that comes to mind is the URL of the wheel, then if could be the license or whatever else.

This means that the metadata we store in the pip attribute gets overridden every time a new variant is added/installed. This is very bad.

Rez's design is unfortunately playing against us here. There is only a single package definition for a package (keeping in mind that a package is a version and a version can contain variants). There is no native way to store variant specific metadata.

@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Metadata is now stored on a variant basis Metadata is not stored on a per variant basis Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant