Skip to content
This repository has been archived by the owner on May 11, 2023. It is now read-only.

bug: Check dataset shapes when adding. #3

Open
daniel-dodd opened this issue Dec 20, 2022 · 0 comments
Open

bug: Check dataset shapes when adding. #3

daniel-dodd opened this issue Dec 20, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@daniel-dodd
Copy link
Member

The __add__ method that concatenates two jaxutils.Dataset's does not provide any checks for both dataset batch shapes. Though this will error via jnp.concatenate, it would be nice to write a function that checks shapes and gives a clear error message to users.

@daniel-dodd daniel-dodd added bug Something isn't working good first issue Good for newcomers labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant